Horton

Re: Asynchronous Append on postgres_fdw nodes.

Andrei Lepikhov <a.lepikhov@postgrespro.ru>

View thread View on postgr.es
From: Andrey Lepikhov <a.lepikhov@postgrespro.ru>
To: Etsuro Fujita <etsuro.fujita@gmail.com>, movead li <movead.li@highgo.ca>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Date: 2020-06-03T10:00:06Z
Lists: pgsql-hackers 
On 3/30/20 1:15 PM, Etsuro Fujita wrote:
> Hi,
> 
> On Wed, Mar 11, 2020 at 10:47 AM movead li <movead.li@highgo.ca> wrote:
> 
>> I redo the make installcheck-world as Kyotaro Horiguchi point out and the
>> result nothing wrong. And I think the patch is good in feature and performance
>> here is the test result thread I made before:
>> https://www.postgresql.org/message-id/CA%2B9bhCK7chd0qx%2Bmny%2BU9xaOs2FDNJ7RaxG4%3D9rpgT6oAKBgWA%40mail.gmail.com
>>
>> The new status of this patch is: Ready for Committer
> 
> As discussed upthread, this is a material for PG14, so I moved this to
> the next commitfest, keeping the same status.  I've not looked at the
> patch in any detail yet, so I'm not sure that that is the right status
> for the patch, though.  I'd like to work on this for PG14 if I have
> time.

Hi,
This patch no longer applies cleanly.
In addition, code comments contain spelling errors.

-- 
Andrey Lepikhov
Postgres Professional
https://postgrespro.com
The Russian Postgres Company

Commits

  1. Improve comments for trivial_subqueryscan().

  2. Disable asynchronous execution if using gating Result nodes.

  3. Allow asynchronous execution in more cases.

  4. Doc: Further update documentation for asynchronous execution.

  5. Fix rescanning of async-aware Append nodes.

  6. Doc: Update documentation for asynchronous execution.

  7. Fix EXPLAIN ANALYZE for async-capable nodes.

  8. Minor code cleanup in asynchronous execution support.

  9. Adjust input value to WaitEventSetWait() in ExecAppendAsyncEventWait().

  10. Add support for asynchronous execution.