Re: Remove useless casts to (void *)

Andreas Karlsson <andreas@proxel.se>

From: Andreas Karlsson <andreas@proxel.se>

To: Peter Eisentraut <peter@eisentraut.org>, Tom Lane <tgl@sss.pgh.pa.us>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-11-28T03:54:32Z

Lists: pgsql-hackers

On 11/14/24 9:59 AM, Peter Eisentraut wrote:
> I'm more concerned that many of these just keep getting copied around 
> indiscriminately, and this is liable to hide actual type mismatches or 
> silently discard qualifiers.  So I'm arguing in favor of a more 
> restrictive style in this matter.

+1 I agree. This is likely to hide real issues.

Andreas

Commits

Remove PointerIsValid()
- a5b35fcedb54 19 (unreleased) landed
Define __EXTENSIONS__ on Solaris, too.
- 3b08d5224d7d 18.0 landed
Define _POSIX_C_SOURCE as 200112L on Solaris.
- 32a7deb2a02b 18.0 landed
Remove useless casts to (void *)
- 7f798aca1d5d 18.0 landed