Horton
Menu

Re: Parallel workers stats in pg_stat_database

Benoit Lobréau <benoit.lobreau@dalibo.com>

View thread
From: Benoit Lobréau <benoit.lobreau@dalibo.com>
To: Michael Banck <mbanck@gmx.net>, Guillaume Lelarge <guillaume@lelarge.info>
Cc: Michael Paquier <michael@paquier.xyz>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-11-12T14:56:11Z
Lists: pgsql-hackers 
On 11/12/24 15:05, Michael Banck wrote:
> I was wondering about the weird new column name workers_to_launch when I
> read the commit message - AFAICT this has been an internal term so far,
> and this is the first time we expose it to users?
> 
> I personally find (parallel_)workers_planned/launched clearer from a
> user perspective, was it discussed that we need to follow the internal
> terms here? If so, I missed that discussion in this thread (and the
> other thread that lead to cf54a2c00).
> 
> 
> Michael

I initiallly called it like that but changed it to mirror the column
name added in pg_stat_statements for coherence sake. I prefer "planned"
but english is clearly not my strong suit and I assumed it meant that
the number of worker planned could change before execution. I just
checked in parallel.c and I don't think it's the case, could it be done
elsewhere ?

-- 
Benoit Lobréau
Consultant
http://dalibo.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add two attributes to pg_stat_database for parallel workers activity

  2. Introduce two fields in EState to track parallel worker activity