Horton

Thread

Commits

  1. Make new auto_explain test safe for log_error_verbosity = verbose.

  1. TAP tests vs log_error verbosity=verbose

    Andrew Dunstan <andrew@dunslane.net> — 2022-07-31T16:10:24Z

    Twice recently (b998196bb5 and 19408aae7f) I have had to adjust new TAP
tests to handle log_error_verbosity=verbose, and there's a third case
needing adjustment in the new auto_explain tests (7c34555f8c). I'm
wondering if it would be better to set log_error_verbosity to default
for TAP tests, no matter what's in TEMP_CONFIG.  An individual TAP test
could still set log_error_verbosity=verbose explicitly if it wanted it.

If not I'm going to change one of my buildfarm animals to use
log_error_verbosity=verbose so we catch things like this earlier.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

  2. Re: TAP tests vs log_error verbosity=verbose

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-07-31T16:14:56Z

    Andrew Dunstan <andrew@dunslane.net> writes:
> Twice recently (b998196bb5 and 19408aae7f) I have had to adjust new TAP
> tests to handle log_error_verbosity=verbose, and there's a third case
> needing adjustment in the new auto_explain tests (7c34555f8c). I'm
> wondering if it would be better to set log_error_verbosity to default
> for TAP tests, no matter what's in TEMP_CONFIG.  An individual TAP test
> could still set log_error_verbosity=verbose explicitly if it wanted it.

> If not I'm going to change one of my buildfarm animals to use
> log_error_verbosity=verbose so we catch things like this earlier.

I think it's good to be able to enable log_error_verbosity=verbose
in case you need to track down some kind of problem.  So I'd vote
for your second approach.

7c34555f8c is mine, so I'll go fix that.

			regards, tom lane

  3. Re: TAP tests vs log_error verbosity=verbose

    Andrew Dunstan <andrew@dunslane.net> — 2022-07-31T16:57:43Z

    On 2022-07-31 Su 12:14, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> Twice recently (b998196bb5 and 19408aae7f) I have had to adjust new TAP
>> tests to handle log_error_verbosity=verbose, and there's a third case
>> needing adjustment in the new auto_explain tests (7c34555f8c). I'm
>> wondering if it would be better to set log_error_verbosity to default
>> for TAP tests, no matter what's in TEMP_CONFIG.  An individual TAP test
>> could still set log_error_verbosity=verbose explicitly if it wanted it.
>> If not I'm going to change one of my buildfarm animals to use
>> log_error_verbosity=verbose so we catch things like this earlier.
> I think it's good to be able to enable log_error_verbosity=verbose
> in case you need to track down some kind of problem.  So I'd vote
> for your second approach.
>
> 7c34555f8c is mine, so I'll go fix that.
>
> 			



Thanks. prion should now catch future instances.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com