Horton

Re: 039_end_of_wal: error in "xl_tot_len zero" test

Anton Voloshin <a.voloshin@postgrespro.ru>

View thread View on postgr.es
From: Anton Voloshin <a.voloshin@postgrespro.ru>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2024-02-15T09:40:37Z
Lists: pgsql-hackers 
Hello, Thomas,

On 19/01/2024 01:35, Thomas Munro wrote:
> I don't yet have an opinion on the best way to
> do it though.  Would it be enough to add emit_message($node, 0) after
> advance_out_of_record_splitting_zone()?

Yes, indeed that seems to be enough. At least I could not produce any 
more "xl_tot_len zero" failures with that addition.

I like this solution the best.

> Tolerating the two different messages would weaken the test.

I agree, I also don't really like this option.

-- 
Anton Voloshin
Postgres Professional, The Russian Postgres Company
https://postgrespro.ru

Commits

  1. Stabilize 039_end_of_wal test.

  2. Create syscache entries for pg_extension