Horton

Re: Make --help output fit within 80 columns per line

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: torikoshia <torikoshia@oss.nttdata.com>, Masahiro Ikeda <ikedamsh@oss.nttdata.com>
Cc: Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2023-09-21T07:45:22Z
Lists: pgsql-hackers 
On 31.08.23 09:47, torikoshia wrote:
> BTW, psql --help outputs the content of PGHOST, which caused a failure 
> in the test:
> 
> ```
> -h, --host=HOSTNAME      database server host or socket directory
>                           (default: 
> "/var/folders/m7/9snkd5b54cx_b4lxkl9ljlcc0000gn/T/LobrmSUf7t")
> ```
> 
> It may be overkill, added a logic for removing the content of PGHOST.

I wonder, should we remove this?  We display the 
environment-variable-based defaults in psql --help, but not for any 
other programs.  This is potentially misleading.

Commits

  1. Add test for checking the line length of --help output

  2. Remove environment-variable-based defaults in psql --help