Horton
Menu

Re: tests for pg_stat_progress_copy.tuples_skipped

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: jian he <jian.universality@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-03T09:05:23Z
Lists: pgsql-hackers

Attachments


On 2025/01/10 23:50, jian he wrote:
> hi.
> seems no regress tests for pg_stat_progress_copy.tuples_skipped.
> 
> CopyFrom
> pgstat_progress_update_param(PROGRESS_COPY_TUPLES_SKIPPED,
>                                cstate->num_errors);
> 
> there is coverage for it. but in regress test, we didn't really print
> out this value (cstate->num_errors)
> 
> The attached patch did minor changes on src/test/regress/sql/copy.sql.
> so we can check if pgstat_progress_update_param(PROGRESS_COPY_TUPLES_SKIPPED..)
> is working as intended or not.

Thanks for the patch!

The patch basically looks good to me.
I’ve made some minor cosmetic adjustments — the updated patch is attached.

Unless there are any objections, I'm thinking to commit it.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add regression tests for pg_stat_progress_copy.tuples_skipped.