Horton

Re: [RFC] Removing "magic" oids

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org
Date: 2018-11-22T04:32:07Z
Lists: pgsql-hackers 
On 11/21/18 7:14 PM, Andres Freund wrote:
>   Could you check whether you
> still encounter the issue after applying the attached fix?
>


This has largely fixed the problem, so I think this should be applied. 
With some adjustments to the tests to remove problematic cases (e.g. 
postgres_fdw's ft_pg_type) the tests pass. The exception is HEAD->HEAD. 
The change is that the LOs are not dumped in the same order pre and post 
upgrade. I can change the tests to allow for a greater fuzz factor - 
generally when the source and target are the same we don't allow any 
fuzz. Or if we care we could do a better job of dumping LOs in a 
consistent order.


cheers


andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Revive test of concurrent OID generation.

  2. Fix typo introduced in 578b229718.

  3. Fix pg_upgrade for oid removal.

  4. Fix sepgsql compile error caused by oid removal.

  5. Remove WITH OIDS support, change oid catalog column visibility.