Horton

Re: Fix most -Wundef warnings

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Mark Dilger <hornschnorter@gmail.com>, pgsql-hackers@postgresql.org
Date: 2019-10-19T16:51:33Z
Lists: pgsql-hackers 
On 2019-10-14 17:12, Mark Dilger wrote:
> The check on HSTORE_IS_HSTORE_NEW goes back at least as far as 2006, 
> suggesting it was needed for migrating from some version pre-9.0, making 
> me wonder if anybody would need this in the field.  Should we drop 
> support for this?  I don't have a strong reason to advocate dropping 
> support other than that this #define appears to be undocumented.

Per subsequent messages in this thread, this issue is outside the scope
of my patch, so I proceeded with my patch as I had proposed it.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix most -Wundef warnings

  2. Remove some code for old unsupported versions of MSVC