Horton

Re: File API cleanup

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-12-23T08:33:58Z
Lists: pgsql-hackers

Attachments

On 01.12.22 09:25, Peter Eisentraut wrote:
> Here are a couple of patches that clean up the internal File API and 
> related things a bit:

Here are two follow-up patches that clean up some stuff related to the 
earlier patch set.  I suspect these are all historically related.

0001-Remove-unnecessary-casts.patch

     Some code carefully cast all data buffer arguments for data write
     and read function calls to void *, even though the respective
     arguments are already void *.  Remove this unnecessary clutter.

0002-Add-const-to-BufFileWrite.patch

     Make data buffer argument to BufFileWrite a const pointer and bubble
     this up to various callers and related APIs.  This makes the APIs
     clearer and more consistent.

Commits

  1. Update types in smgr API

  2. Add const to BufFileWrite

  3. Remove unnecessary casts

  4. Update types in File API