Horton

Re: [PATCH] (Windows) psql echoes password when reading from pipe

Matthew Stickney <mtstickney@gmail.com>

View thread View on postgr.es
From: Matthew Stickney <mtstickney@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-05-23T19:29:29Z
Lists: pgsql-hackers

Attachments

The attached is a patch that uses the _fileno/_get_osfhandle approach. 
This doesn't address the stdin fallback, or error handling if opening 
termin fails; however, it should be no worse than what's there now, and 
it fixes the immediate problem.

I'm still thinking about the fallback in terms of a mintty-type 
environment, but I wanted to get this patch out there in the meantime.

-Matt Stickney

Commits

  1. Fix simple_prompt() to disable echo on Windows when stdin != terminal.