Re: Rework of collation code, extensibility

Jeff Davis <pgsql@j-davis.com>

From: Jeff Davis <pgsql@j-davis.com>

To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Peter Geoghegan <pg@bowt.ie>

Cc: pgsql-hackers@postgresql.org

Date: 2023-01-31T23:33:10Z

Lists: pgsql-hackers

On Tue, 2023-01-31 at 11:40 +0100, Peter Eisentraut wrote:
> I don't know to what extent this depends on the abbreviated key GUC 
> discussion.  Does the rest of this patch set depend on this?

The overall refactoring is not dependent logically on the GUC patch. It
may require some trivial fixup if you eliminate the GUC patch.

I left it there because it makes exploring/testing easier (at least for
me), but the GUC patch doesn't need to be committed if there's no
consensus.

Regards,
	Jeff Davis

Commits

Remove unnecessary #ifdef USE_ICU and branch.
- e0b3074e8944 16.0 landed
Refactor to introduce pg_locale_deterministic().
- 6974a8f7682b 16.0 landed
Refactor to add pg_strcoll(), pg_strxfrm(), and variants.
- d87d548cd030 16.0 landed
Fix MSVC build
- c971a5b27ac9 16.0 cited