Re: logical decoding and replication of sequences

Tomas Vondra <tomas.vondra@enterprisedb.com>

From: Tomas Vondra <tomas.vondra@enterprisedb.com>

To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Petr Jelinek <petr.jelinek@enterprisedb.com>

Date: 2022-03-10T22:49:35Z

Lists: pgsql-hackers

Attachments

0001-Add-support-for-decoding-sequences-to-built-20220310.patch (text/x-patch) patch 0001

On 3/10/22 12:07, Peter Eisentraut wrote:
> On 23.02.22 00:24, Tomas Vondra wrote:
>> Here's an updated version of the patch, fixing most of the issues from
>> reviews so far. There's still a couple FIXME comments, but I think those
>> are minor and/or straightforward to deal with.
> 
> This patch needs a rebase because of a conflict in
> expected/publication.out.  In addition, see the attached fixup patch to
> get the pg_dump tests passing (and some other stuff).
> 

OK, rebased patch attached.

> 028_sequences.pl should be renamed to 029, since there is now another 028.
> 

Renamed.

> In psql, the output of \dRp and \dRp+ is inconsistent.  The former shows
> 
> All tables | All sequences | Inserts | Updates | Deletes | Truncates |
> Sequences | Via root
> 
> the latter shows
> 
> All tables | All sequences | Inserts | Updates | Deletes | Sequences |
> Truncates | Via root
> 
> I think the first order is the best one.
> 

Good idea, I've tweaked the code to use the former order.

> That's all for now, I'll come back with more reviewing later.


thanks

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

Fix cache invalidation bug in recovery_prefetch.
- d0d934490020 15.0 landed
- 932b01630095 16.0 landed
Revert "Logical decoding of sequences"
- 2c7ea57e56ca 15.0 landed
Minor improvements in sequence decoding code and docs
- 05843b1aa49d 15.0 landed
Handle sequences in preprocess_pubobj_list
- 002c9dd97a0c 15.0 landed
Update tab-completion for CREATE PUBLICATION with sequences
- 2d2232933b02 15.0 landed
Add decoding of sequences to built-in replication
- 75b1521dae1f 15.0 landed
Stabilize test_decoding touching with sequences
- a180c2b34de0 15.0 landed
Call ReorderBufferProcessXid from sequence_decode
- d5ed9da41d96 15.0 landed
Add decoding of sequences to test_decoding
- 80901b32913f 15.0 landed
Replace Test::More plans with done_testing
- 549ec201d613 15.0 cited
Logical decoding of sequences
- 0da92dc530c9 15.0 landed
Respect permissions within logical replication.
- a2ab9c06ea15 15.0 cited