Re: doc: modify the comment in function libpqrcv_check_conninfo()
Rintaro Ikeda <ikedarintarof@oss.nttdata.com>
From: ikedarintarof <ikedarintarof@oss.nttdata.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: pgsql-hackers@postgresql.org
Date: 2024-06-27T10:27:33Z
Lists: pgsql-hackers
Attachments
- 0001-modify-the-commnet-in-libpqrcv_check_conninfo.patch (text/x-diff) patch 0001
Thanks for your suggestion. I used ChatGPT to choose the wording, but it's still difficult for me. The new patch includes your suggestion. On 2024-06-27 17:18, Jelte Fennema-Nio wrote: > On Thu, 27 Jun 2024 at 09:09, ikedarintarof > <ikedarintarof@oss.nttdata.com> wrote: >> >> Thank you for your comment! >> >> I've added the must_use_password argument. A new patch is attached. > > s/whther/whether > > nit: "it will do nothing" sounds a bit strange to me (but I'm not > native english). Something like this reads more natural to me: > > an error. If must_use_password is true, the function raises an error > if no password is provided in the connection string. In any other case > it successfully completes.
Commits
-
Fix comment in libpqrcv_check_conninfo().
- 629520be5f9d 18.0 landed