Re: [PATCH] Add Windows support for backtrace_functions (MSVC only)

Bryan Green <dbryan.green@gmail.com>

From: Bryan Green <dbryan.green@gmail.com>
To: Michael Paquier <michael@paquier.xyz>, Jakub Wartak <jakub.wartak@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Date: 2025-10-27T17:58:31Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Add backtrace support for Windows using DbgHelp API

On 10/20/2025 3:40 AM, Michael Paquier wrote:
> On Mon, Oct 20, 2025 at 10:10:25AM +0200, Jakub Wartak wrote:
>> Cool, thanks for working on this. Win32 is a bit alien to me, but I've
>> got access to win32 so I've played with the patch a little bit. With
>> simple: SET backtrace_functions = 'typenameType'; CREATE TABLE tab (id
>> invalidtype);
> 
> Perhaps it would be possible to add some WIN32-specific tests that
> check some log patterns based on the backtraces printed?  (I have not
> read the patch in details, just an idea while passing by.)
> --
> Michael
Michael,
    Thanks for even glancing at this.  I did not add any regression 
tests because the output goes to the server log and not the client.

BG