Horton

Re: Check for tuplestorestate nullness before dereferencing

Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>

View thread
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
To: kuznetsovam@altlinux.org, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Cc: nickel@altlinux.org, egori@altlinux.org
Date: 2024-10-14T13:41:53Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Create infrastructure for 'MinimalTuple' representation of in-memory

  2. Teach nodeSort and nodeMaterial to optimize out unnecessary overhead

On 14.10.2024 12:25, Alexander Kuznetsov wrote:
> Hello everyone,
>
> I'd like to propose adding a check for the nullness of tuplestorestate 
> before dereferencing it
> in src/backend/executor/nodeModifier.c. The patch is attached.
>
> I am proposing this fix based on the assumption that tuplestorestate 
> could be NULL
> since there is a check for it when calculating eof_tuplestore at line 85.
> However, since this code hasn't been changed since 2006 and hasn't 
> caused any issues,
> it is possible that the check for (tuplestorestate == NULL) is 
> redundant when calculating eof_tuplestore.
>

Hi Alexander,

The 'tuplestorestate' variable may be initialized at line 64 if it is 
NULL. You should consider initializing this variable earlier.

Regards,
Ilia Evdokimov,
Tantor Labs LLC.