Re: Fix help option of contrib/oid2name

Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>

From: Tatsuro Yamada <yamada.tatsuro@lab.ntt.co.jp>
To: Michael Paquier <michael@paquier.xyz>, Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-hackers@postgresql.org
Date: 2018-08-17T07:03:21Z
Lists: pgsql-hackers

Attachments

On 2018/08/17 12:42, Tatsuro Yamada wrote:
> On 2018/08/17 11:47, Michael Paquier wrote:
>> On Thu, Aug 16, 2018 at 08:57:57PM +0900, Michael Paquier wrote:
>>> I agree on both points.  Any objections if I apply what's proposed here
>>> on HEAD?
>>
>> I have been looking at this patch.  And while consistency is nice, I
>> think that if we are cleaning up this stuff we could do a bit more to
>> be more consistent with the other binary tools:
>> - Addition of long options for connection options.
>> - removal of -h, and use it for host value instead of "-H".
>> - Use "USERNAME" instead of "NAME" in help().
>>
>> vacuumlo could also be improved a bit...
> 
> Yeah, I'll revise the patch based on your suggestions.

I created WIP patch for oid2name and vacuumlo includes followings:

   oid2name and vacuumlo
   - Add long options

   only oid2name
   - Replace -H with -h
   - Replace NAME with USERNAME

I'll revise their documents and create new patch next week, probably. :)

Regards,
Tatsuro Yamada

Commits

  1. Rework option set of vacuumlo

  2. Rework option set of oid2name