Horton
Menu

Re: Changing the state of data checksums in a running cluster

Tomas Vondra <tomas@vondra.me>

View thread
From: Tomas Vondra <tomas@vondra.me>
To: Palak Chaturvedi <chaturvedipalak1911@gmail.com>, pgsql-hackers@postgresql.org
Date: 2026-07-02T08:29:53Z
Lists: pgsql-hackers 
On 7/2/26 07:06, Palak Chaturvedi wrote:
> Hi Tomas,
> 
> Thanks for these test patches. They are quite useful. I've been going
> through them because we think they'll also help with the TAP tests for
> the online shared_buffers resize work , where I'm ending up reusing
> several of the same helpers (attach_injection_points,
> background_rw_pgbench, and a couple of others).
> Would you be open to lifting these helpers out into a shared Perl module
> (for example under src/test/perl/PostgreSQL/Test/…) so both test suites
> can consume them instead of each copy-pasting? I'm happy to prepare a
> small prep patch on top of your latest version if that sounds reasonable
> to you.
> 

I suppose you mean the functions for managing injection points (waiting,
waking, attachin/detaching, ...)? Yes, it might be useful to have that
in a Perl module, so feel free to create one.


regards

-- 
Tomas Vondra

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Use correct datatype for PID

  2. Improve comments in online checksums code

  3. Fix checksum state transition during promotion

  4. Fix regex searching for page verification failures in tests

  5. Apply data-checksum worker throttling parameters

  6. Skip WAL for unlogged main fork during online checksum enable

  7. Fix data_checksum GUC show_hook

  8. Improve database detection logic in datachecksumsworker

  9. Improve handling of concurrent checksum requests

  10. Typo and spelling fixups for online checksums

  11. Fix invalid checksum state transition in checkpoints

  12. Handle data_checksum state changes during launcher_exit

  13. Test improvements for online checksums

  14. Prevent pg_enable/disable_data_checksums() on standby

  15. Test stabilization for online checksums

  16. Make data checksum tests more resilient for slow machines

  17. Formalize WAL record for XLOG_CHECKPOINT_REDO

  18. Revert "Get rid of WALBufMappingLock"

  19. Get rid of WALBufMappingLock

  20. Improve grammar of options for command arrays in TAP tests