Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

Alexey Kondratov <a.kondratov@postgrespro.ru>

From: Alexey Kondratov <a.kondratov@postgrespro.ru>

To: Michael Paquier <michael@paquier.xyz>

Cc: Justin Pryzby <pryzby@telsasoft.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, Steve Singer <steve@ssinger.info>, pgsql-hackers@lists.postgresql.org, Robert Haas <robertmhaas@gmail.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Masahiko Sawada <sawada.mshk@gmail.com>, Jose Luis Tallon <jltallon@adv-solutions.net>

Date: 2020-11-30T14:12:42Z

Lists: pgsql-hackers

Attachments

v31-0005-Implement-vacuum-full-cluster-INDEX_TABLESPACE-t.patch (text/x-diff) patch v31-0005
v31-0004-Allow-CLUSTER-and-VACUUM-FULL-to-change-tablespa.patch (text/x-diff) patch v31-0004
v31-0003-Refactor-and-reuse-set_rel_tablespace.patch (text/x-diff) patch v31-0003
v31-0002-Allow-REINDEX-to-change-tablespace.patch (text/x-diff) patch v31-0002
v31-0001-Change-REINDEX-CLUSTER-to-accept-an-option-list.patch (text/x-diff) patch v31-0001

On 2020-11-30 14:33, Michael Paquier wrote:
> On Tue, Nov 24, 2020 at 09:31:23AM -0600, Justin Pryzby wrote:
>> @cfbot: rebased
> 
> Catching up with the activity here, I can see four different things in
> the patch set attached:
> 1) Refactoring of the grammar of CLUSTER, VACUUM, ANALYZE and REINDEX
> to support values in parameters.
> 2) Tablespace change for REINDEX.
> 3) Tablespace change for VACUUM FULL/CLUSTER.
> 4) Tablespace change for indexes with VACUUM FULL/CLUSTER.
> 
> I am not sure yet about the last three points, so let's begin with 1)
> that is dealt with in 0001 and 0002.  I have spent some time on 0001,
> renaming the rule names to be less generic than "common", and applied
> it.  0002 looks to be in rather good shape, still there are a few
> things that have caught my eyes.  I'll look at that more closely
> tomorrow.
> 

Thanks. I have rebased the remaining patches on top of 873ea9ee to use 
'utility_option_list' instead of 'common_option_list'.


Regards
-- 
Alexey Kondratov

Postgres Professional https://www.postgrespro.com
Russian Postgres Company

Commits

Add TABLESPACE option to REINDEX
- c5b286047cd6 14.0 landed
Refactor code in tablecmds.c to check and process tablespace moves
- 4c9c359d38ff 14.0 landed
Refactor option handling of CLUSTER, REINDEX and VACUUM
- a3dc926009be 14.0 landed
pg_dump: Don't use enums for defining bit mask values
- d2a2808eb444 14.0 landed
Refactor CLUSTER and REINDEX grammar to use DefElem for option lists
- b5913f612079 14.0 landed
Refactor parsing rules for option lists of EXPLAIN, VACUUM and ANALYZE
- 873ea9ee692e 14.0 landed
Improve tab completion of REINDEX in psql
- 1f75b454134c 14.0 landed
Fix possible crash during FATAL exit from reindexing.
- d12bdba77b0f 13.0 cited