Horton

Re: Generating code for query jumbling through gen_node_support.pl

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>, "Drouvot, Bertrand" <bdrouvot@amazon.com>
Date: 2023-01-23T13:27:13Z
Lists: pgsql-hackers

Attachments

On 21.01.23 04:35, Michael Paquier wrote:
>> I'll read the 0003 again more carefully.  I haven't studied the new 0004
>> yet.
> 
> Thanks, again.  Rebased version attached.

A couple of small fixes are attached.

There is something weird in _jumbleNode().  There are two switch 
(nodeTag(expr)) statements.  Maybe that's intentional, but then it 
should be commented better, because now it looks more like an editing 
mistake.

The handling of T_RangeTblEntry could be improved.  In other contexts we 
have for example a custom_copy attribute, which generates the switch 
entry but not the function.  Something like this could be useful here too.

Otherwise, this looks ok.  I haven't checked whether it maintains the 
exact behavior from before.  What is the test coverage situation for this?

For the 0004 patch, it should be documented why one would want one 
behavior or the other.  That's totally unclear right now.

I think if we are going to accept 0004, then it might be better to 
combine it with 0003.  Otherwise, 0004 is just undoing a lot of the code 
structure changes in JumbleQuery() that 0003 did.

Commits

  1. Mark more nodes with attribute no_query_jumble

  2. Include values of A_Const nodes in query jumbling

  3. Generate code for query jumbling through gen_node_support.pl

  4. Rework format of comments in headers for nodes

  5. Move queryjumble.c code to src/backend/nodes/

  6. Fix some compiler warnings in aset.c and generation.c

  7. Reformat some node comments