Horton

Re: [BUG] Logical replica crash if there was an error in a function.

Anton A. Melnikov <aamelnikov@inbox.ru>

View thread View on postgr.es
From: "Anton A. Melnikov" <aamelnikov@inbox.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: vignesh C <vignesh21@gmail.com>, Andres Freund <andres@anarazel.de>, Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Maxim Orlov <orlovmg@gmail.com>
Date: 2023-04-06T10:24:21Z
Lists: pgsql-hackers 
On 05.04.2023 17:35, Tom Lane wrote:
> "Anton A. Melnikov" <aamelnikov@inbox.ru> writes:
>> On 03.04.2023 21:49, Tom Lane wrote:
>>> I did not think this case was worth memorializing in a test before,
>>> and I still do not.  I'm inclined to reject this patch.
> 
>> Could you help me to figure out, please.
> 
> The problem was an Assert that was speculative when it went in,
> and which we eventually found was wrong in the context of logical
> replication.  We removed the Assert.  I don't think we need a test
> case to keep us from putting back the Assert.  That line of thinking
> leads to test suites that run for fourteen hours and are near useless
> because developers can't run them easily.
> 
> 			regards, tom lane

Ok, i understand! Thanks a lot for the clarification. A rather important point,
i'll take it into account for the future.
Let's do that. Revoked the patch.

With the best wishes!

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

  1. Avoid crash after function syntax error in a replication worker.