Horton

Returning non-terminated string in ECPG Informix-compatible function

Oleg Tselebrovskiy <o.tselebrovskiy@postgrespro.ru>

View thread View on postgr.es
From: o.tselebrovskiy@postgrespro.ru
To: pgsql-hackers@postgresql.org
Date: 2024-01-29T08:47:31Z
Lists: pgsql-hackers

Attachments

Greetings, everyone!

While analyzing output of Svace static analyzer [1] I've found a bug.

In function intoasc(interval * i, char *str) from file 
src/interfaces/ecpg/compatlib/informix.c
we return a non-terminated string since we use memcpy on tmp which is 
itself NULL-teminated but
last zero byte is not copied.

The proposed solution is to use strcpy instead, since it is used in all 
other functions in informix.c.

The patch is attached.

[1] - https://svace.pages.ispras.ru/svace-website/en/

Oleg Tselebrovskiy, Postgres Pro

Commits

  1. ecpg: Fix zero-termination of string generated by intoasc()

  2. ecpg: Fix error handling on OOMs when parsing timestamps