Re: pgsql: Refactor dlopen() support

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: pgsql-hackers@lists.postgresql.org

Date: 2018-09-07T16:27:28Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Work around stdbool problem in dfmgr.c.
- ff47d4bf1f20 12.0 landed
Refactor dlopen() support
- 842cb9fa62fc 12.0 cited

On 07/09/2018 16:19, Tom Lane wrote:
> Somehow or other, the changes you made in dfmgr.c's #include lines
> have made it so that find_rendezvous_variable's local "bool found"
> variable is actually of type _Bool (which is word-wide on these
> machines).  However, hash_search thinks its output variable is
> of type pointer to "typedef char bool".  The proximate cause of
> the observed failure is that find_rendezvous_variable sees "found"
> as true when it should not, and thus fails to zero out the variable's
> value.

Ah because dlfcn.h includes stdbool.h.  Hmm.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services