Horton

Re: [UNVERIFIED SENDER] Re: Minimal logical decoding on standbys

bdrouvotAWS <bdrouvot@amazon.com>

View thread
From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
To: <fabriziomello@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Amit Khandekar <amitdkhan.pg@gmail.com>, Rahila Syed <rahila.syed@2ndquadrant.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>, tushar <tushar.ahuja@enterprisedb.com>, "[pgdg] Robert Haas" <robertmhaas@gmail.com>
Date: 2021-01-26T09:31:33Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Reduce the log level in 035_standby_logical_decoding.pl.

  2. 035_standby_logical_decoding: Add missing waits for replication

  3. For cascading replication, wake physical and logical walsenders separately

  4. Handle logical slot conflicts on standby

  5. Support invalidating replication slots due to horizon and wal_level

  6. Prevent use of invalidated logical slot in CreateDecodingContext()

  7. Replace replication slot's invalidated_at LSN with an enum

  8. Pass down table relation into more index relation functions

  9. Assert only valid flag bits are passed to visibilitymap_set()

  10. Remove unused _bt_delitems_delete() argument.

  11. Add xl_btree_delete optimization.

Attachments

Hi,

On 1/25/21 8:34 PM, Fabrízio de Royes Mello wrote:
>
> On Mon, Jan 18, 2021 at 8:48 AM Drouvot, Bertrand <bdrouvot@amazon.com 
> <mailto:bdrouvot@amazon.com>> wrote:
> >
> > 3 and 4 were failing because the 
> ResolveRecoveryConflictWithLogicalSlots() call was missing in 
> ResolveRecoveryConflictWithSnapshot(): the new version attached adds it.
> >
> > The new version attached also provides a few changes to make it 
> compiling on the current master (it was not the case anymore).
> >
> > I also had to change 023_standby_logical_decoding_conflicts.pl 
> <http://023_standby_logical_decoding_conflicts.pl> (had to call 
> $node_standby->create_logical_slot_on_standby($node_master, 
> 'otherslot', 'postgres'); at the very beginning of the "DROP DATABASE 
> should drops it's slots, including active slots" section)
> >
>
> Awesome and thanks a lot.
>
> Seems your patch series is broken... can you please `git format-patch` 
> and send again?

Thanks for pointing out!

Enclosed a new series created with "format-patch" and that can be 
applied with "git am":

$ git am v8-000*.patch
Applying: Allow logical decoding on standby.
Applying: Add info in WAL records in preparation for logical slot 
conflict handling.
Applying: Handle logical slot conflicts on standby.
Applying: New TAP test for logical decoding on standby.
Applying: Doc changes describing details about logical decoding.

Bertrand