Re: Column Filtering in Logical Replication

Tomas Vondra <tomas.vondra@enterprisedb.com>

From: Tomas Vondra <tomas.vondra@enterprisedb.com>

To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Amit Kapila <amit.kapila16@gmail.com>

Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Justin Pryzby <pryzby@telsasoft.com>, Rahila Syed <rahilasyed90@gmail.com>, Peter Smith <smithpb2250@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>

Date: 2022-03-17T19:11:32Z

Lists: pgsql-hackers

Attachments

0001-Allow-specifying-column-filters-for-logical-20220317.patch (text/x-patch) patch 0001

On 3/17/22 15:17, Peter Eisentraut wrote:
> I notice that the publication.sql regression tests contain a number of
> comments like
> 
> +-- error: replica identity "a" not included in the column list
> +ALTER PUBLICATION testpub_fortable ADD TABLE testpub_tbl5 (b, c);
> 
> but the error doesn't actually happen, because of the way the replica
> identity checking was changed.  This needs to be checked again.

But the comment describes the error for the whole block, which looks
like this:

-- error: replica identity "a" not included in the column list
ALTER PUBLICATION testpub_fortable ADD TABLE testpub_tbl5 (b, c);
UPDATE testpub_tbl5 SET a = 1;
ERROR:  cannot update table "testpub_tbl5"
DETAIL:  Column list used by the publication does not cover the replica
identity.

So IMHO the comment is correct.

But there was one place where it wasn't entirely clear, as the block was
split by another comment. So I tweaked it to:

-- error: change the replica identity to "b", and column list to (a, c)
-- then update fails, because (a, c) does not cover replica identity

Attached is a rebased patch, on top of the two fixes I pushed.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Doc: Explain about Column List feature.
- f98d07424523 16.0 landed
- 25996a82a446 15.0 landed
Doc: fix column list vs. replica identity rules.
- 376af686111e 16.0 landed
- ab3131880d8a 15.0 landed
Prohibit combining publications with different column lists.
- fd0b9dcebda7 15.0 cited
Fix the check to limit sync workers.
- be46985bed8a 10.21 landed
- a90de822e483 11.16 landed
- 59348fbdeb7b 12.11 landed
- 82d4a17a1750 13.7 landed
- c9dea58e2702 14.3 landed
- dd4ab6fd6528 15.0 landed
Wait for subscription to sync in t/031_column_list.sql
- 404f49338fef 15.0 landed
Move prattrs to the pg_publication_rel section in docs
- 41b00f8e601f 15.0 landed
Allow specifying column lists for logical replication
- 923def9a533a 15.0 landed
Fix row filters with multiple publications
- 5a079662256e 15.0 landed
Fix publish_as_relid with multiple publications
- 27fafee72d17 13.7 landed
- 677a1dc0ca0f 14.3 landed
- c91f71b9dc91 15.0 landed
Add some additional tests for row filters in logical replication.
- ceb57afd3ce1 15.0 cited
Add index on pg_publication_rel.prpubid
- 025b920a3d45 15.0 landed
Avoid using DefElemAction in AlterPublicationStmt
- 9623d8999603 15.0 landed
Small cleanups related to PUBLICATION framework code
- c9105dd3660f 15.0 landed
Add PublicationTable and PublicationRelInfo structs
- 0c6828fa987b 15.0 landed
Fix various concurrency issues in logical replication worker launching
- de4389712206 10.0 cited