Re: Failed to request an autovacuum work-item in silence

Ildar Musin <i.musin@postgrespro.ru>

From: Ildar Musin <i.musin@postgrespro.ru>
To: Masahiko Sawada <sawada.mshk@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-03-12T09:26:15Z
Lists: pgsql-hackers
Hi,

autovac_get_workitem_name() declaration seems redundant and should be 
removed. The same thing with including "utils/lsyscache.h" in brin.c.

The 'requested' variable in brininsert() I would again rename to 
something like 'success' because a work item is requested anyway but 
what matters is whether the request was satisfied/successful.

Except for those two points everything is fine and works as expected.


-- 
Ildar Musin
i.musin@postgrespro.ru


Commits

  1. Log when a BRIN autosummarization request fails