Re: EDB Installer initcluster script changes - review requested

Vladlen Popolitov <v.popolitov@postgrespro.ru>

From: Vladlen Popolitov <v.popolitov@postgrespro.ru>

To: Manika Singhal <manika.singhal@enterprisedb.com>

Cc: pgsql-hackers@lists.postgresql.org, Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>, Dave Page <dave.page@enterprisedb.com>, thomas.munro@gmail.com, noah@leadboat.com

Date: 2025-01-28T18:21:50Z

Lists: pgsql-hackers

Manika Singhal писал(а) 2025-01-28 16:42:
> Hi,

> "C:\Users\Administrator\AppData\Local\Temp\2\postgresql_installer_cd746730f8"
>> "C:\Program Files\PostgreSQL\17" "C:\Program
>> Files\PostgreSQL\17\data" 5432 "Turkish,Türkiye" 0

Hi!

  Your example has not-ascii characters in command line. It is not good 
practice.
If user switched on "Use UTF-8" flag in locale settings (it is user's 
right to do it
on own computer), it forces all commands
use UTF-8 characters in command line. "Türkiye" will be transformed to 
wrong text
by exec system call.

  "Use UTF-8" flag appeared in Windows 10. It helps correctly input and 
output
UTF-8 text (including correct behaviour of psql.exe utility under 
Windows).
As consequence, it consider as obsolete all programs that uses national
chars in command line or do not expect UTF-8 in command line.

> --------------------------------
> Thanks & Regards
> Manika Singhal
> EDB Pune
> 
> 
> 
> Links:
> ------
> [1] https://github.com/EnterpriseDB/edb-installers/issues/98
> [2] 
> https://www.postgresql.org/message-id/CA+hUKGL5mBN3JQuebAPbX0yxDNtpui04J+KSy2F7KBbhLGaJig@mail.gmail.com

-- 
Best regards,

Vladlen Popolitov.