Horton
Menu

Re: Amcheck verification of GiST and GIN

Tomas Vondra <tomas@vondra.me>

View thread
From: Tomas Vondra <tomas@vondra.me>
To: Thom Brown <thom@linux.com>
Cc: Arseniy Mukhin <arseniy.mukhin.dev@gmail.com>, Andrey Borodin <x4mmm@yandex-team.ru>, Tom Lane <tgl@sss.pgh.pa.us>, Kirill Reshke <reshkekirill@gmail.com>, Mark Dilger <mark.dilger@enterprisedb.com>, Alexander Lakhin <exclusion@gmail.com>, Andrey Borodin <amborodin86@gmail.com>, Peter Geoghegan <pg@bowt.ie>, Jose Arthur Benetasso Villanova <jose.arthur@gmail.com>, Andres Freund <andres@anarazel.de>, Nikolay Samokhvalov <samokhvalov@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-06-17T14:26:17Z
Lists: pgsql-hackers 
On 6/17/25 16:19, Thom Brown wrote:
> On Mon, 16 Jun 2025 at 21:00, Tomas Vondra <tomas@vondra.me> wrote:
>>
>> On 6/16/25 21:09, Arseniy Mukhin wrote:
>>> On Mon, Jun 16, 2025 at 6:58 PM Tomas Vondra <tomas@vondra.me> wrote:
>>>>
>>>> Thanks.
>>>>
>>>> I went through the patches, polished the commit messages and did some
>>>> minor tweaks in patch 0002 (to make the variable names a bit more
>>>> consistent, and reduce the scope a little bit). I left it as a separate
>>>> patch to make the changes clearer, but it should be merged into 0002.
>>>>
>>>> Please read through the commit messages, and let me know if I got some
>>>> of the details wrong (or not clear enough). Otherwise I plan to start
>>>> pushing this soon (~tomorrow).
>>>
>>> LGTM.
>>> Noticed a few typos in messages:
>>> in v8-0002-amcheck-Fix-checks-of-entry-order-for-GIN-indexes.patch
>>>    - parent key is creator
>>>    - as the core incorrectly expected
>>> and 'Arseniy Mikhin' in some patches.
>>>
>>
>> Thanks for noticing those typos, especially the one in the name.
> 
> Do today's commits clear this from the PostgreSQL 18 Open Items list?
> 

That's the intent, yes. There's one remaining commit.


-- 
Tomas Vondra

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. amcheck: Fix posting tree checks in gin_index_check()

  2. amcheck: Fix parent key check in gin_index_check()

  3. amcheck: Fix checks of entry order for GIN indexes

  4. amcheck: Remove unused GinScanItem->parentlsn field

  5. amcheck: Test gin_index_check on a multicolumn index

  6. Remove incidental md5() function use from test

  7. amcheck: Add a GIN index to the CREATE INDEX CONCURRENTLY tests

  8. amcheck: Add a test with GIN index on JSONB data

  9. amcheck: Fix indentation in verify_gin.c

  10. amcheck: Add gin_index_check() to verify GIN index

  11. amcheck: Move common routines into a separate module

  12. Fix grammar in GIN README

  13. Avoid amcheck inline compression false positives.