Re: [BUG]Invalidate relcache when setting REPLICA IDENTITY

Euler Taveira <euler@eulerto.com>

From: "Euler Taveira" <euler@eulerto.com>
To: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, "Amit Kapila" <amit.kapila16@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>
Date: 2021-11-12T19:17:16Z
Lists: pgsql-hackers
On Fri, Nov 12, 2021, at 3:10 AM, houzj.fnst@fujitsu.com wrote:
> On Fri, Nov 12, 2021 1:33 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > On Fri, Nov 12, 2021 at 10:50 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > But won't that generate invalidation for the rel twice in the case
> > > (change Replica Identity from Nothing to some index) you mentioned in
> > > the previous email?
> > >
> > 
> > Oh, I see the point. I think this is okay because
> > AddRelcacheInvalidationMessage doesn't allow to add duplicate rel
> > invalidation. If that is the case I wonder why not simply register
> > invalidation without any check in the for loop as was the case with
> > Tang's original patch?
> 
> OK, I also think the code in Tang's original patch is fine.
> Attach the patch which register invalidation without any check in the for loop.
WFM.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

Commits

  1. Invalidate relcache when changing REPLICA IDENTITY index.