Re: longfin missing gssapi_ext.h
Jonathan S. Katz <jkatz@postgresql.org>
From: "Jonathan S. Katz" <jkatz@postgresql.org>
To: Stephen Frost <sfrost@snowman.net>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>,
pgsql-hackers@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>,
Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: 2023-04-12T14:40:53Z
Lists: pgsql-hackers
On 4/12/23 10:33 AM, Stephen Frost wrote: > Greetings, > > * Tom Lane (tgl@sss.pgh.pa.us) wrote: >> Stephen Frost <sfrost@snowman.net> writes: >>> Understood. Please find attached the updated patch with changes to the >>> commit message to indicate that we now require MIT Kerberos, an >>> additional explicit check for gssapi_ext.h in configure.ac/configure, >>> along with updated documentation explicitly saying we require MIT >>> Kerberos for GSSAPI support. >> >> Um ... could you package this as a straight un-revert of the >> previous commit, then a delta patch? Would be easier to review. > > Sure, reworked that way and attached. Docs read well. A few questions/commenets: * On [1] -- do we want to add a note that it's not just Kerberos, but MIT Kerberos? * On [2] -- we mention "kadmin tool of MIT-compatible Kerberos 5" which is AIUI is still technically correct, but do we want to drop the "-compatible?" (precedent in [3]) Thanks, Jonathan [1] https://www.postgresql.org/docs/devel/install-requirements.html [2] https://www.postgresql.org/docs/devel/gssapi-auth.html [3] https://www.postgresql.org/docs/devel/regress-run.html
Commits
-
Further cleanup of autoconf output files for GSSAPI changes.
- d48ac0070cff 16.0 landed
-
Update Kerberos/GSSAPI configure/meson check
- 1c52f9c042fb 16.0 landed
-
Explicitly require MIT Kerberos for GSSAPI
- f7431bca8b01 16.0 landed
-
De-Revert "Add support for Kerberos credential delegation"
- 6633cfb21691 16.0 landed
-
Revert "Add support for Kerberos credential delegation"
- 3d03b24c350a 16.0 landed