Re: WIP: parallel GiST index builds

Tomas Vondra <tomas@vondra.me>

From: Tomas Vondra <tomas@vondra.me>

To: Michael Paquier <michael@paquier.xyz>

Cc: "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Andreas Karlsson <andreas@proxel.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2024-10-08T13:05:38Z

Lists: pgsql-hackers

Attachments

v20241008-0001-WIP-parallel-GiST-build.patch (text/x-patch) patch v20241008-0001
v20241008-0002-use-GetFakeLSNForUnloggedRel.patch (text/x-patch) patch v20241008-0002

On 10/8/24 04:05, Michael Paquier wrote:
> On Tue, Jul 30, 2024 at 11:05:56AM +0200, Tomas Vondra wrote:
>> I tried implementing this, see the attached 0002 patch that replaces the
>> fake LSN with an atomic counter in shared memory. It seems to work (more
>> testing needed), but I can't say I'm very happy with the code :-(
> 
> While scanning quickly the code, please be careful about the query ID
> that should be passed down to _gist_parallel_build_main()..

Here's an updated patch adding the queryid.


regards

-- 
Tomas Vondra