Horton

Re: GUC flags

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>, Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@lists.postgresql.org, Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2021-12-08T12:23:51Z
Lists: pgsql-hackers 
On 08.12.21 07:27, Michael Paquier wrote:
>> I saw that Tom updated it within the last 12 months, which I took to mean that
>> it was still being maintained. But I'm okay with removing it.
> Yes, I saw that as of bf8a662.  With 42 incorrect reports, I still see
> more evidence with removing it.  Before doing anything, let's wait for
> and gather some opinions.  I am adding Bruce (as the original author)
> and Tom in CC as they are the ones who have updated this script the
> most in the last ~15 years.

I wasn't really aware of this script either.  But I think it's a good 
idea to have it.  But only if it's run automatically as part of a test 
suite run.

Commits

  1. Add TAP test to automate the equivalent of check_guc, take two

  2. Retire src/backend/utils/misc/check_guc

  3. Add TAP test to automate the equivalent of check_guc

  4. Add PostgreSQL::Test::Cluster::config_data()

  5. Introduce pg_settings_get_flags() to find flags associated to a GUC

  6. Revert changes about warnings/errors for placeholders.

  7. Improve the description of various GUCs