Horton

Re: Stale description for pg_basebackup

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-04-23T06:53:02Z
Lists: pgsql-hackers 

On 2021/04/22 13:25, Kyotaro Horiguchi wrote:
> At Thu, 22 Apr 2021 13:06:50 +0900, Fujii Masao <masao.fujii@oss.nttdata.com> wrote in
>> Either works for me. I didn't add "()" because I just used the same
>> description
>> as that in func.sgml.
>>
>>          it may be useful to run <function>pg_switch_wal</function> on the
>>          primary in order to trigger an immediate segment switch.)
> ..
>> IMO "in order to..." part is helpful for us to understand why
>> pg_switch_wal
>> is useful in this case. So I'd like to leave it.
> 
> Ok, I'm fine with both of them. Thanks for the explanation.

Pushed. Thanks!

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. doc: Fix obsolete description about pg_basebackup.

  2. Make pg_stop_backup's wait_for_archive flag work on standbys.