Re: pgindent vs. git whitespace check
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>, John Naylor <john.naylor@enterprisedb.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-02-23T11:37:17Z
Lists: pgsql-hackers
On 2023-02-22 We 23:48, Tom Lane wrote: > For my own taste, I really don't have any objection to // in isolation -- > the problem with it is just that we've got megabytes of code in the other > style. I fear it'd look really ugly to have an intermixture of // and /* > comment styles. Maybe, I've seen some mixing elsewhere and it didn't make me shudder. I agree that you probably wouldn't want to mix both styles for end of line comments in a single function, although a rule like that would be hard to enforce mechanically. > Mass conversion of /* to // style would answer that, > but would also create an impossible back-patching problem. > > Yeah, I agree that's a complete non-starter. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com
Commits
-
Fix comment indentation and whitespace
- 62d56f6720cd 16.0 landed