Re: Don't use the deprecated and insecure PQcancel in our frontend tools anymore

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>

To: Jelte Fennema-Nio <postgres@jeltef.nl>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Jacob Champion <jacob.champion@enterprisedb.com>

Date: 2026-07-06T16:27:56Z

Lists: pgsql-hackers

Attachments

v8.1-0001-psql-Replace-cancel_pressed-with-CancelRequeste.patch (text/x-patch) patch v8-0001
v8.1-0002-fe_utils-Simplify-cancel-logic-in-wait_on_slots.patch (text/x-patch) patch v8-0002
v8.1-0003-Move-Windows-pthread-compatibility-functions-to.patch (text/x-patch) patch v8-0003
v8.1-0004-Don-t-use-deprecated-and-insecure-PQcancel-psql.patch (text/x-patch) patch v8-0004

On 06/07/2026 13:28, Jelte Fennema-Nio wrote:
> On Sun, 5 Jul 2026 at 00:58, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> I extracted just the comment in fe_utils/cancel.c to a separate patch,
>> and modified it to reflect the reality before the rest of the changes.
>> I'm inclined to commit that now to document the status quo. That'll also
>> make it easier to see what the other patches change. Does the attached
>> look correct to you?
> 
> Sounds good and yeah looks correct.

Thanks, pushed that part. Attached are the remaining patches, rebased 
over that.

- Heikki