Re: Concurrent ALTER SEQUENCE RESTART Regression

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

To: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>

Cc: Michael Paquier <michael.paquier@gmail.com>, Jason Petersen <jason@citusdata.com>, PostgreSQL mailing lists <pgsql-bugs@postgresql.org>

Date: 2017-06-13T19:04:35Z

Lists: pgsql-bugs, pgsql-hackers

Attachments

0001-Use-RangeVarGetRelidExtended-in-AlterSequence.patch (text/plain) patch 0001

On 5/2/17 12:45, Robert Haas wrote:
> Another thing that doesn't look so good about AlterSequence is that it
> uses RangeVarGetRelid() instead of RangeVarGetsRelidExtended() with
> RangeVarCallbackOwnsRelation or some derivative thereof.  That of
> course means you can obstruct access to a sequence you don't own.

Here is a patch for this.  Note that this is old code, but it seems
worth fixing now while we're at it.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

Make ALTER SEQUENCE, including RESTART, fully transactional.
- 3d79013b970d 10.0 landed
Modify sequence catalog tuple before invoking post alter hook.
- 665104557fdc 10.0 landed
Use weaker locks when updating pg_subscription_rel
- 521fd4795e3e 10.0 cited
Add pg_sequence system catalog
- 1753b1b02703 10.0 cited
Modify sequence state storage to eliminate dangling-pointer problem
- a2597ef17958 7.3.1 cited