Re: Re: allow online change primary_conninfo
David Steele <david@pgmasters.net>
From: David Steele <david@pgmasters.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Sergei Kornilov <sk@zsrv.org>, Andres Freund <andres@anarazel.de>,
Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2019-03-25T08:32:21Z
Lists: pgsql-hackers
Hi Michael, On 3/4/19 7:19 AM, Michael Paquier wrote: > On Sat, Mar 02, 2019 at 01:49:51PM +0300, Sergei Kornilov wrote: >> This might be not the right way, but I can't think of a better way >> to not switch to a different method than split of lastSourceFailed >> processing and starting new source. Something like refactoring in >> first attached patch. I move RequestXLogStreaming logic from >> lastSourceFailed processing and add new pendingRestartSource >> indicator. > > OK. This needs a rather close lookup, and I am not actually sure that > you even need pendingRestartSource. Please let me a couple of days > before coming back to you on 0001. > >> Second patch is mostly the same as previous version but uses new >> pendingRestartSource mechanism instead of lastSourceFailed. > > This, on the other hand, looks like the implementation we are looking > for based on the discussions which happened until now to have the > startup process handle the shutdown and restart of the WAL receiver. Do you know when you'll have a chance to revisit this? Regards, -- -David david@pgmasters.net
Commits
-
Allow walreceiver configuration to change on reload
- 1e6148032e4d 13.0 landed