Re: ON CONFLICT DO SELECT (take 3)

Viktor Holmberg <v@viktorh.net>

From: Viktor Holmberg <v@viktorh.net>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: jian he <jian.universality@gmail.com>, pgsql-hackers@postgresql.org
Date: 2025-11-19T19:54:58Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Add support for INSERT ... ON CONFLICT DO SELECT.

  2. doc: Fix statement about ON CONFLICT and deferrable constraints.

  3. Fix ON CONFLICT ON CONSTRAINT during REINDEX CONCURRENTLY

On 19 Nov 2025 at 18:19 +0100, Dean Rasheed <dean.a.rasheed@gmail.com>, wrote:
> On Wed, 19 Nov 2025 at 16:51, Viktor Holmberg <v@viktorh.net> wrote:
> >
> > For the CASE default, elog(ERROR, "unrecognized LockClauseStrength %d” that was removed.
> > Would this now trigger a compile time error/warning? And are you supposed to get 0 warnings when compiling?
> That shouldn't trigger a warning, because there is a case block for
> every enum element, and yes there should be 0 compiler warnings.
Yes sorry, that’s what I meant! In that case, nice that those potential future errors are moved from runtime to compile time.
> > (I get a large amount of warnings "warning: 'pg_restrict' macro redefined" on master, but that could just be something with my environment)
> I haven't seen that before, but there's this thread:
>
> https://www.postgresql.org/message-id/flat/CA%2BFpmFdoa7O7yS3k7ZtqvA%2BhNWUA6YvJy6VvdYX1sGsryVQBNQ%40mail.gmail.com
>
> If you re-run configure, does it go away?
>
> Regards,
> Dean
Yes, re-configuring made the warning go away. Thanks for pointing me in the right direction.