Re: Support LIKE with nondeterministic collations

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: jian he <jian.universality@gmail.com>

Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Jacob Champion <jacob.champion@enterprisedb.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Daniel Verite <daniel@manitou-mail.org>, Paul A Jungwirth <pj@illuminatedcomputing.com>

Date: 2024-11-27T08:01:26Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Support LIKE with nondeterministic collations
- 85b7efa1cdd6 18.0 landed

On 20.11.24 08:29, jian he wrote:
> in match_pattern_prefix maybe change
>      if (expr_coll && !get_collation_isdeterministic(expr_coll))
>          return NIL;
> to
>      if (OidIsValid(expr_coll) && !get_collation_isdeterministic(expr_coll))
>          return NIL;

I left it like it was, because this was existing code that I'm just 
moving around.

> other than that, I didn't find any issue.

I have committed it, thanks.