Re: Convert sepgsql tests to TAP
Peter Eisentraut <peter@eisentraut.org>
From: Peter Eisentraut <peter@eisentraut.org>
To: Andreas Karlsson <andreas@proxel.se>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-07-24T16:33:53Z
Lists: pgsql-hackers
On 24.07.24 16:31, Andreas Karlsson wrote: > I took a quick look at the patch and I like that we standardize things a > bit. But one thing I am not a fan of are all the use of sed and awk in > the Perl script. I would prefer if that logic happened all in Perl, > especially since we have some of it in Perl (e.g. chomp). Also I wonder > if we should not use IPC::Run to do the tests since we already depend on > it for the other TAP tests. In principle yes, but here I tried not rewriting the tests too much but just port them to a newer environment. I think the adjustments you describe could be done as a second step. (I don't really have any expertise in sepgsql or selinux, I'm just doing this to reduce the dependency on makefiles for testing. So I'm trying to use as light a touch as possible.)
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
sepgsql: update TAP test to use fat comma style
- cc2c9fa6960c 18.0 landed
-
Convert sepgsql tests to TAP
- aeb8ea361a0a 18.0 landed
-
meson: Fix sepgsql installation
- 155d6162e457 16.7 landed
- 24c5b73eb6ec 17.3 landed
- 02ed3c2bdcef 18.0 landed