Add reject_limit option to file_fdw
torikoshia <torikoshia@oss.nttdata.com>
From: torikoshia <torikoshia@oss.nttdata.com>
To: Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2024-10-17T13:45:46Z
Lists: pgsql-hackers
Attachments
- v1-0001-file_fdw-Add-reject_limit-option-to-file_fdw.patch (text/x-diff) patch v1-0001
Hi, 4ac2a9bec introduced reject_limit option to the COPY command, and I was wondering if it might be beneficial to add the same option to file_fdw. Although there may be fewer practical use cases compared to COPY, it could still be useful in situations where the file being read via file_fdw is subject to modifications and there is a need to tolerate a limited number of errors. What do you think? I've attached a patch. Based on the synopsis of the CREATE/ALTER FOREIGN TABLE commands, the value for the foreign table's option must be single-quoted. I’m not entirely sure if this is the correct approach, but in order to accommodate this, the patch modifies the value of reject_limit option to accept not only numeric values but also strings. -- Regards, -- Atsushi Torikoshi NTT DATA Group Corporation
Commits
-
file_fdw: Add regression tests for ON_ERROR and other options.
- 631db1d4b251 18.0 landed
-
file_fdw: Add REJECT_LIMIT option to file_fdw.
- 6c8f670323d2 18.0 landed