Re: Failed assertion on standby while shutdown

Fujii Masao <masao.fujii@oss.nttdata.com>

From: Fujii Masao <masao.fujii@oss.nttdata.com>

To: Maxim Orlov <m.orlov@postgrespro.ru>, pgsql-hackers@lists.postgresql.org

Date: 2021-04-01T12:02:09Z

Lists: pgsql-hackers

Attachments

fix_assertion_failure_walreceiver_v2.patch (text/plain) patch v2


On 2021/03/31 19:51, Maxim Orlov wrote:
> On 2021-03-30 20:44, Maxim Orlov wrote:
>> The following review has been posted through the commitfest application:
>> make installcheck-world:  tested, passed
>> Implements feature:       tested, passed
>> Spec compliant:           not tested
>> Documentation:            not tested
>>
>> All the tests passed successfully.
>>
>> The new status of this patch is: Ready for Committer
> 
> The patch is good. One note, should we put a comment about ShutdownRecoveryTransactionEnvironment not reentrant behaviour? Or maybe rename it to ShutdownRecoveryTransactionEnvironmentOnce?

+1 to add more comments into ShutdownRecoveryTransactionEnvironment().
I did that. What about the attached patch?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

Shut down transaction tracking at startup process exit.
- e3bf9621632c 9.6.22 landed
- b9cf9d7d3bed 10.17 landed
- b59d3abaf406 11.12 landed
- dd5b7e486a4f 12.7 landed
- e7bcfd717ef3 13.3 landed
- ad8b674922eb 14.0 landed