Re: Minor fixes for upcoming version 13
Alexander Law <exclusion@gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-09-09T16:16:16Z
Lists: pgsql-hackers
Hello Tom, 09.09.2020 18:29, Tom Lane wrote: > Alexander Lakhin <exclusion@gmail.com> writes: >> Please consider fixing minor defects in the source code and documentation. > I agree with all of these, except the markup fixes in bgworker.sgml > still seem not right; it should be more like > > <function>RegisterBackgroundWorker(<type>BackgroundWorker</type> *<parameter>worker</parameter>)</function> Yes, but I've tried to minimize the change and align with the adjacent text. For example: <para>Once running, the process can connect to a database by calling <function>BackgroundWorkerInitializeConnection(<parameter>char *dbname</parameter>... >> 6. "unhandled previous state in xqs" -> "unhandled previous state at end >> quote"? >> "xqs" is rather cryptic for a user-visible message > But it's not user-visible is it? That should surely be a can't-happen > case. I've encountered this while translating NLS messages in postgres.po and ecpg.po. So I think it should at least puzzle translators. Best regards, Alexander
Commits
-
Minor fixes in docs and error messages.
- aa33187164e1 13.0 landed
- f3e1e6619655 14.0 landed