Horton

Thread

Commits

  1. Fix typo in reorderbuffer.c.

  1. fix typo in ReorderBufferProcessTXN

    Hou, Zhijie <houzj.fnst@cn.fujitsu.com> — 2021-01-05T00:54:29Z

    Hi

I found a possible typo in the comment of  ReorderBufferProcessTXN().

* relmapper has no "historic" view, in contrast to normal
* the normal catalog during decoding. Thus repeated

Is there an extra ‘normal’ in the comment ?

in contrast to normal the normal catalog during decoding == >> in contrast to the normal catalog during decoding

Best regards,
houzj

  2. Re: fix typo in ReorderBufferProcessTXN

    Masahiko Sawada <sawada.mshk@gmail.com> — 2021-01-05T01:42:17Z

    On Tue, Jan 5, 2021 at 9:54 AM Hou, Zhijie <houzj.fnst@cn.fujitsu.com> wrote:
>
> Hi
>
>
>
> I found a possible typo in the comment of  ReorderBufferProcessTXN().
>
>
>
> * relmapper has no "historic" view, in contrast to normal
>
> * the normal catalog during decoding. Thus repeated
>
>
>
> Is there an extra ‘normal’ in the comment ?

Yeah, I think so.

> in contrast to normal the normal catalog during decoding == >> in contrast to the normal catalog during decoding

Looks good change to me.

Regards,

-- 
Masahiko Sawada
EnterpriseDB:  https://www.enterprisedb.com/

  3. Re: fix typo in ReorderBufferProcessTXN

    Amit Kapila <amit.kapila16@gmail.com> — 2021-01-05T02:15:57Z

    On Tue, Jan 5, 2021 at 7:13 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Tue, Jan 5, 2021 at 9:54 AM Hou, Zhijie <houzj.fnst@cn.fujitsu.com> wrote:
>
> > in contrast to normal the normal catalog during decoding == >> in contrast to the normal catalog during decoding
>
> Looks good change to me.
>

+1. I will push this in some time.

-- 
With Regards,
Amit Kapila.

  4. Re: fix typo in ReorderBufferProcessTXN

    Amit Kapila <amit.kapila16@gmail.com> — 2021-01-05T03:05:51Z

    On Tue, Jan 5, 2021 at 7:45 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Jan 5, 2021 at 7:13 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > On Tue, Jan 5, 2021 at 9:54 AM Hou, Zhijie <houzj.fnst@cn.fujitsu.com> wrote:
> >
> > > in contrast to normal the normal catalog during decoding == >> in contrast to the normal catalog during decoding
> >
> > Looks good change to me.
> >
>
> +1. I will push this in some time.
>

Pushed.

-- 
With Regards,
Amit Kapila.