Horton

Re: pread() and pwrite()

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@enterprisedb.com>, Jesper Pedersen <jesper.pedersen@redhat.com>, Magnus Hagander <magnus@hagander.net>, Oskari Saarenmaa <os@ohmu.fi>, Pg Hackers <pgsql-hackers@postgresql.org>, Tobias Oberstein <tobias.oberstein@gmail.com>
Date: 2018-10-09T18:50:15Z
Lists: pgsql-hackers 

On 10/09/2018 02:37 PM, Andres Freund wrote:
> On 2018-10-09 14:32:29 -0400, Andrew Dunstan wrote:
>>
>> On 10/08/2018 09:55 PM, Tom Lane wrote:
>>> Thomas Munro <thomas.munro@enterprisedb.com> writes:
>>>> Rebased again.  Patches that touch AC_CHECK_FUNCS are fun like that!
>>> Yeah, I've been burnt by that too recently.  It occurs to me we could make
>>> that at least a little less painful if we formatted the macro with one
>>> line per function name:
>>>
>>> AC_CHECK_FUNCS([
>>> 	cbrt
>>> 	clock_gettime
>>> 	fdatasync
>>> 	...
>>> 	wcstombs_l
>>> ])
>>>
>>> You'd still get conflicts in configure itself, of course, but that
>>> doesn't require manual work to resolve -- just re-run autoconf.
>>>
>>> 			
>>
>>
>> By and large I think it's better not to submit patches with changes to
>> configure, but to let the committer run autoconf.
>> OTOH, this will probably confuse the heck out of the cfbot patch checker.
> And make life harder for reviewers.
>
> -1 on this one.
>


Maybe I'm thinking back to the time when we used to use a bunch of old 
versions of autoconf ...

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Use pg_pread() and pg_pwrite() for data files and WAL.

  2. Provide pg_pread() and pg_pwrite() for random I/O.

  3. Convert some long lists in configure.in to one-line-per-entry style.