Re: Using defines for protocol characters
Peter Eisentraut <peter@eisentraut.org>
From: Peter Eisentraut <peter@eisentraut.org>
To: Dave Cramer <davecramer@gmail.com>, Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com,
alvherre@alvh.no-ip.org, smithpb2250@gmail.com,
pgsql-hackers@lists.postgresql.org
Date: 2023-08-09T15:19:20Z
Lists: pgsql-hackers
1. As was discussed, these definitions should go into src/include/libpq/pqcomm.h, not a new file. 2. I would prefer an underscore after PgMsg, like PqMsg_DescribeRequest, so it's easier to visually locate the start of the actual message name. 3. IMO, the names of the protocol messages in protocol.sgml are canonical. Your patch appends "Request" and "Response" in cases where that is not part of the actual name. Also, some messages are documented to go both ways, so this separation doesn't make sense strictly speaking. Please use the names as in protocol.sgml without augmenting them.
Commits
-
Introduce macros for protocol characters.
- f4b54e1ed985 17.0 landed
-
Remove configure check for z_streamp
- eeb4eeea2c52 17.0 cited