Horton

Re: Avoid a possible null pointer (src/backend/utils/adt/pg_locale.c)

Jeff Davis <pgsql@j-davis.com>

View thread View on postgr.es
From: Jeff Davis <pgsql@j-davis.com>
To: Michael Paquier <michael@paquier.xyz>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: ranier.vf@gmail.com, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
Date: 2023-09-13T15:14:11Z
Lists: pgsql-hackers 
On Wed, 2023-09-13 at 11:48 +0900, Michael Paquier wrote:
> Hmm.  I see your point, one could be confused that the function name
> is the provider with this wording.  How about that instead:
>  ERROR:  unsupported collprovider for %s: %c
> 
> I've hidden that in a macro that uses __func__ as Jeff has suggested.
> 
> What do you think?

Looks good to me, thank you.

Regards,
	Jeff Davis

Commits

  1. Refactor error messages for unsupported providers in pg_locale.c