Horton

Re: Patch to address creation of PgStat* contexts with null parent context

Drouvot, Bertrand <bdrouvot@amazon.com>

View thread View on postgr.es
From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, <andres@anarazel.de>
Cc: <reid.thompson@crunchydata.com>, <pgsql-hackers@lists.postgresql.org>
Date: 2022-09-07T09:11:11Z
Lists: pgsql-hackers

Attachments

Hi,

On 9/6/22 7:53 AM, Kyotaro Horiguchi wrote:
> At Mon, 5 Sep 2022 14:46:55 +0200, "Drouvot, Bertrand"<bdrouvot@amazon.com>  wrote in
>> Looks like that both approaches have their pros and cons. I'm tempted
>> to vote +1 on "just changing" the parent context to TopMemoryContext
>> and not changing the allocations locations.
> Yeah. It is safe more than anything and we don't have a problem there.
>
> So, I'm fine with just replacing the parent context at the three places.

Attached a patch proposal to do so.

Regards,

-- 

Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services:https://aws.amazon.com

Commits

  1. pgstat: Create memory contexts below TopMemoryContext