Horton

Re: BUG #18500: Detaching a partition with an index manually attached to the parent's index triggers Assert

Laurenz Albe <laurenz.albe@cybertec.at>

View thread
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Michael Paquier <michael@paquier.xyz>, Tender Wang <tndrwang@gmail.com>, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2024-06-29T19:10:33Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix ALTER TABLE DETACH for inconsistent indexes

On Sat, 2024-06-29 at 19:56 +0200, Alvaro Herrera wrote:
> On 2024-Jun-29, Laurenz Albe wrote:
> 
> > My example that triggered this assert runs just fine on v16.
> 
> Well, in a build without assertions enabled then yes it doesn't crash.
> But if you do have asserts enabled in 16, it does crash.
> 
> > So while an error is clearly better than a crash, that would constitute
> > a regression.  Is that really unavoidable?  It would be very unfortunate
> > if the only way to detach a partition would be to drop some indexes first...
> 
> The error would not occur on detach, but on attach, and it'd be intended
> to prevent an inconsistent situation.  I'm proposing that on older
> branches we do what Tender proposed elsewhere, namely to cope with the
> detach without crashing (and without leaving inconsistent catalog state,
> such as bogus coninhcount values).


I should have read more closely, sorry.  That's great then; sorry for the noise.

Yours,
Laurenz Albe