Re: docs: note ownership requirement for refreshing materialized views
Dian Fay <dian.m.fay@gmail.com>
From: Dian Fay <dian.m.fay@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers@lists.postgresql.org
Date: 2018-08-16T13:36:29Z
Lists: pgsql-hackers
Attachments
- 0001-docs-note-ownership-requirement-for-refreshing-mater.patch (text/x-patch) patch 0001
Fair enough! Here's a new version. On 8/16/18 12:07 AM, Tom Lane wrote: > Dian Fay <dian.m.fay@gmail.com> writes: >> I feel resorting to the infinitive asks more involvement of the reader, >> while leading with the responsible role(s) helps shortcut the process of >> determining whether what follows is relevant. Efficiency is always a >> virtue, although this is admittedly more than a little academic for a >> one-sentence addition! > I think Michael's point is that this formulation is unlike what we have > elsewhere for similar statements. Looking around, it seems like the > typical phraseology would be more like > > "You must own the materialized view to use REFRESH MATERIALIZED VIEW." > > It is not really customary to call out the superuser exception > explicitly, because if we did, we'd be mentioning superusers in every > other sentence. The point is covered by existing documentation that > says something to the effect of superusers bypassing all permissions > checks; and I think there's also a statement somewhere about superusers > implicitly being members of every role, which is a different way of > arriving at the same conclusion. > > In any case, it's definitely an oversight that the REFRESH reference > page fails to address permissions at all. +1 for adding something. > > regards, tom lane
Commits
-
Mention ownership requirements for REFRESH MATERIALIZED VIEW in docs
- b6c994af1f0d 9.3.25 landed
- 777192f0dd44 9.4.20 landed
- 82784f088986 9.5.15 landed
- 86e873c01650 9.6.11 landed
- 0dfaf8f763ae 10.6 landed
- b43cf1dcded9 11.0 landed
- ee8012481190 12.0 landed